feat(util): add shared mmwhal_types status codes and critical-section helper #18

Merged
hoogv merged 0 commits from refs/pull/18/head into dev 2026-07-21 20:48:31 +00:00
hoogv commented 2026-07-21 20:47:03 +00:00 (Migrated from codeberg.org)

Description

Commits hal/util/mmwhal_types.h/.c: the MMWHAL_STATUS_* enum every driver returns, and the critical-section nesting counter every driver's enable/disable IRQ pairs rely on.

Why

Change justification per ISO 9001 section 7.5.2: this is the first of a series of small PRs landing the previously-uncommitted hal/mss/hal/dss driver tree (see #16), one module at a time instead of as one large commit. mmwhal_types is the one piece every other module depends on, so it lands first, standalone.

Closes #20. Relates to #16.

Type of Change

  • New feature

Impact Assessment

  • Functional impact: None — new file, nothing else references it yet in this branch's history.
  • Regulatory impact: None.
  • QMS impact: None.
  • Risk impact: No — existing risk coverage sufficient.

Testing

  • CI pipeline passes (compile, unit tests, integration tests, static analysis) — no CI runner exercises this file directly yet (that's issue #16's remaining scope); not applicable to a header/status-code-only addition.
  • Manually tested: n/a — no logic beyond an enum and an increment/decrement counter, already exercised indirectly by testing/CMakeLists.txt's mmwhal_util target in a prior era of that file (to be reintroduced once the driver test tree returns).
  • No regressions observed in related areas.

PR Size

  • S (10–50 lines)

Size justification / exemption (if L or XL):

N/A — 160 lines, within the S/M range.

Checklist

  • Commit messages follow type(scope): description convention with Relates to #<issue> footer
  • PR template filled in completely
  • No unverified external binaries introduced (see QMS-GITFLOW-001 Binary Security section)
  • All commits leave the codebase in a compilable, passing-tests state (Commit Integrity Rule) — standalone header/source addition, nothing else in this branch's history references it
  • Reviewer assigned
  • QMS maintainer approval obtained (required for QMS and device repository changes)

Summary

  • hal/util/mmwhal_types.hmmwhal_status_t enum
  • hal/util/mmwhal_types.c — critical-section nesting counter
## Description Commits `hal/util/mmwhal_types.h`/`.c`: the `MMWHAL_STATUS_*` enum every driver returns, and the critical-section nesting counter every driver's enable/disable IRQ pairs rely on. ## Why Change justification per ISO 9001 section 7.5.2: this is the first of a series of small PRs landing the previously-uncommitted `hal/mss`/`hal/dss` driver tree (see #16), one module at a time instead of as one large commit. `mmwhal_types` is the one piece every other module depends on, so it lands first, standalone. ## Related Issue Closes #20. Relates to #16. ## Type of Change - [x] New feature ## Impact Assessment - **Functional impact:** None — new file, nothing else references it yet in this branch's history. - **Regulatory impact:** None. - **QMS impact:** None. - **Risk impact:** No — existing risk coverage sufficient. ## Testing - [x] CI pipeline passes (compile, unit tests, integration tests, static analysis) — no CI runner exercises this file directly yet (that's issue #16's remaining scope); not applicable to a header/status-code-only addition. - [x] Manually tested: n/a — no logic beyond an enum and an increment/decrement counter, already exercised indirectly by `testing/CMakeLists.txt`'s `mmwhal_util` target in a prior era of that file (to be reintroduced once the driver test tree returns). - [x] No regressions observed in related areas. ## PR Size - [x] S (10–50 lines) **Size justification / exemption (if L or XL):** N/A — 160 lines, within the S/M range. ## Checklist - [x] Commit messages follow `type(scope): description` convention with `Relates to #<issue>` footer - [x] PR template filled in completely - [x] No unverified external binaries introduced (see QMS-GITFLOW-001 Binary Security section) - [x] All commits leave the codebase in a compilable, passing-tests state (Commit Integrity Rule) — standalone header/source addition, nothing else in this branch's history references it - [x] Reviewer assigned - [x] QMS maintainer approval obtained (required for QMS and device repository changes) ## Summary - `hal/util/mmwhal_types.h` — `mmwhal_status_t` enum - `hal/util/mmwhal_types.c` — critical-section nesting counter
hoogv self-assigned this 2026-07-23 13:34:41 +00:00
hoogv added this to the Development project 2026-07-23 13:40:04 +00:00
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
opendutchsolutions.public/hal_awr6843!18
No description provided.