feat(cbuff): CBUFF driver implementation and host unit tests #88
No reviewers
Labels
No labels
Category
App
Category
Documentation
Category
Firmware
Category
Hardware
Category
Qms
PR_Size
L
PR_Size
M
PR_Size
S
PR_Size
XL
PR_Size
XS
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Very Low Priority
Size
Epic
Size
Feature
Size
Task
Status
Blocked
Status
Draft
Status
Needs-review
Team
Board
Team
Dev
Team
Management
Type
Bug
Type
Capa
Type
Improvement
Type
New-feature
Type
Regulatory
Type
Usability
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
opendutchsolutions.public/hal_awr6843!88
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/87-cbuff-driver"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Adds
hal/mss/cbuff/hal_cbuff.c/.h— the CBUFF (Common Buffer / High-Speed Interface) driver: controller reset + sticky-status clear on init, single-linklist-entry session configuration (LVDS/CSI-2 interface select, sample format, size, CRC enable, HW/SW trigger source), software session-start trigger, an approximate session-active poll, and the two raw device handlers (CBUFF_IRQHandler/CBUFF_ERR_IRQHandler) decodingSTAT_CBUFF_REG0/STAT_CBUFF_REG1to a weak, application-overridablehal_cbuff_irq_handler()hook. Self-contained — no cross-module dependency.Why
Continues the driver-implementation phase started by GPIO (#75/#76), ESM (#77/#78), UART (#79/#80), I2C (#81/#82), SPI (#83/#84), and ADCBUF (#85/#86).
Related Issue
Closes #87
Type of Change
Impact Assessment
Testing
testing/mss/unit/hal_functionality/test_cbuff_functionallocally (14 test cases, 102 assertions, all passing) alongside the full existingctestsuite (249/249 passing, no regressions); ran a full MISRA C:2025 pass (0 unsuppressed findings,-DENABLE_CBUFF_MODULEadded); reformatted and re-verified against the exact clang-format 18.1.3 the CI runner uses; sanity-checked by zeroing theCFG_FRAME_START_TRIGbit inhal_cbuff_trigger_session_start(), confirming the test suite fails (1 assertion), then reverting.PR Size
Size justification / exemption (if L or XL):
806 raw lines across 9 files, all hand-reviewed (no mechanically-generated content). Not split further — the driver (
hal_cbuff.c/.h, 353 lines) and its comprehensive Catch2 spec (test_cbuff.c, 332 lines, covering session configuration validation, the RMW-hazard-free trigger sequence, and both IRQ handlers) don't decompose into independently-reviewable sub-PRs, same rationale as prior driver PRs (#78, #80, #82, #84, #86). The remaining files are small CMake/Kconfig/MISRA wiring diffs (~120 lines total), also not independently reviewable apart from the driver they enable.Checklist
type(scope): descriptionconvention withRelates to #<issue>footerSummary
hal/mss/cbuff/hal_cbuff.c/.h: CBUFF driver (init/reset, session config, SW trigger, session-active poll, IRQ handlers) — deliberately minimal scope (one linklist entry per session), documented in the header's top-of-file commenttesting/mss/unit/hal_functionality/test_cbuff.c(+CMakeLists.txt): Catch2 functional test suite. Namedtest_cbuff_functional(nottest_cbuff) to avoid a CMake target-name collision withti_hal_comparison/test_cbuff.c's register-layout comparison test.zephyr/Kconfig/zephyr/CMakeLists.txt/hal/util/hal_config_mss.h:HAL_AWR6843_CBUFFKconfig option andENABLE_CBUFF_MODULEbridge, same pattern as every other landed drivertools/misra/run_misra.sh:-DENABLE_CBUFF_MODULEadded